Skip to content

chore: Track the supported Rust version automatically - #32

Merged
keelerm84 merged 4 commits into
mainfrom
mk/SDK-3652/rust-version-check
Nov 18, 2026
Merged

keelerm84 merged 4 commits into
mainfrom
mk/SDK-3652/rust-version-check

Conversation

@keelerm84

@keelerm84 keelerm84 commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Summary

hello-rust pinned Rust 1.97.0 in ci.yml and Cargo.toml. The SDK now needs a newer compiler, so CI fails.

This follows the Rust SDK repos. ci.yml reads the toolchain from .github/variables/rust-versions.env, which is set to 1.98 to match rust-server-sdk, and passes it to rustup through an environment variable. check-rust-versions.yml calls the shared sdk-rust-versions.yml workflow from launchdarkly/gh-actions once a day. That workflow opens a chore: Bump MSRV PR that updates the env file and rust-version in Cargo.toml when the target Rust release changes.

The first version of this PR copied the SDK repos' inline workflow, which pastes the endoflife.date response into shell scripts. The shared workflow validates the version first. It comes from launchdarkly/gh-actions#131, so merge this PR after that one.


Note

Overview
Moves the minimum supported Rust version (MSRV) to 1.98 and wires CI to read it from .github/variables/rust-versions.env instead of a hard-coded rustup override in ci.yml. Cargo.toml’s rust-version is updated to 1.98.0 to match.

Adds a daily check-rust-versions workflow that delegates to LaunchDarkly’s shared sdk-rust-versions.yml action so future MSRV bumps can land via automated chore: Bump MSRV PRs (same pattern as the Rust SDK repos).

Reviewed by Cursor Bugbot for commit ddfc416. Bugbot is set up for automated code reviews on this repo. Configure here.

Opened from termag

@keelerm84
keelerm84 requested a review from a team as a code owner November 17, 2026 21:46

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: medium. Cursor Security Agent: SDK Team Security Reviewer did not reach a terminal state within 11 minutes, so this PR is not approved. Human review is needed; no reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: SDK - Pull Request Router and Approver

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit cc3ca3f. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: medium. Cursor Bugbot reported an unresolved high-severity finding and this GitHub Actions change is above the low-risk approval threshold, so the PR is not approved. Human review is needed; no reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: SDK - Pull Request Router and Approver

@keelerm84
keelerm84 merged commit 29690d9 into main Nov 18, 2026
5 of 6 checks passed
@keelerm84
keelerm84 deleted the mk/SDK-3652/rust-version-check branch November 18, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants