Repository navigation
chore: Track the supported Rust version automatically - #32
Merged
Merged
Conversation
Generated-by: termag
Generated-by: termag
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cc3ca3f. Configure here.
Generated-by: termag
kinyoklion
approved these changes
Nov 18, 2026
Generated-by: termag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
hello-rust pinned Rust 1.97.0 in
ci.ymlandCargo.toml. The SDK now needs a newer compiler, so CI fails.This follows the Rust SDK repos.
ci.ymlreads the toolchain from.github/variables/rust-versions.env, which is set to 1.98 to match rust-server-sdk, and passes it torustupthrough an environment variable.check-rust-versions.ymlcalls the sharedsdk-rust-versions.ymlworkflow from launchdarkly/gh-actions once a day. That workflow opens achore: Bump MSRVPR that updates the env file andrust-versioninCargo.tomlwhen the target Rust release changes.The first version of this PR copied the SDK repos' inline workflow, which pastes the endoflife.date response into shell scripts. The shared workflow validates the version first. It comes from launchdarkly/gh-actions#131, so merge this PR after that one.
Note
Overview
Moves the minimum supported Rust version (MSRV) to 1.98 and wires CI to read it from
.github/variables/rust-versions.envinstead of a hard-codedrustup overrideinci.yml.Cargo.toml’srust-versionis updated to 1.98.0 to match.Adds a daily
check-rust-versionsworkflow that delegates to LaunchDarkly’s sharedsdk-rust-versions.ymlaction so future MSRV bumps can land via automatedchore: Bump MSRVPRs (same pattern as the Rust SDK repos).Reviewed by Cursor Bugbot for commit ddfc416. Bugbot is set up for automated code reviews on this repo. Configure here.
Opened from termag